LG-12920: add analytics event for tracking unexpected sdk error #10368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
night-jellyfish
requested review from
a team and
eileen-nava
and removed request for
a team
night-jellyfish
commented
Apr 5, 2024
eileen-nava
reviewed
Apr 8, 2024
charleyf
approved these changes
Apr 9, 2024
There was a problem hiding this comment.
Acuant does not provide any information on what might trigger this. I think having this is better than not having it. We might want to add a note above the
window.AcuantJavascriptWebSdk.setUnexpectedErrorCallback((errorMessage) => {
like Unclear if/how this is called. Implemented just in case, but this is untested.
night-jellyfish
deleted the
brittany/lg-12920-add-acuant-set-unexpected-error-callback
branch
night-jellyfish
added a commit
that referenced
this pull request
Apr 9, 2024
[skip changelog] Suggestion missed in #10368 that I think is a good addition.
night-jellyfish
added a commit
that referenced
this pull request
Apr 9, 2024
[skip changelog] Suggestion missed in #10368 that I think is a good addition.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-12920
🛠 Summary of changes
Implements the
setUnexpectedErrorCallbackmethod from Acuant setup instructions (step #5).We wanted to implement this now in case it gives us useful messages about the black screen issues in LG-12671.
📜 Testing Plan
I could not find a way to test this or to trigger it locally. It needs to be an error that happens after SDK load but before initialization. We would like to have a test for it, or at least have a way to trigger it manually, but we don't believe we have a way to do that.