Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LG-12712 Use phone fingerprint as rate limit key for phone confirmation #10459

Closed
wants to merge 27 commits into from
Closed

LG-12712 Use phone fingerprint as rate limit key for phone confirmation #10459

wants to merge 27 commits into from

Commits on May 1, 2024

  1. changelog: Internal, Fraud Prevention, Use phone fingerprint as rate … 

    …limit key for phone confirmation
    @kevinsmaster5
    kevinsmaster5 committed May 1, 2024
    Configuration menu
    Copy the full SHA
    6c9f694 View commit details
    Browse the repository at this point in the history

  2. add submission limit check to phone setup. config values

    @kevinsmaster5
    kevinsmaster5 committed May 1, 2024
    Configuration menu
    Copy the full SHA
    16ebd44 View commit details
    Browse the repository at this point in the history

  3. move check invocation to before_action

    @kevinsmaster5
    kevinsmaster5 committed May 1, 2024
    Configuration menu
    Copy the full SHA
    97b0596 View commit details
    Browse the repository at this point in the history

  4. fingerprint submissions limit to 20

    @kevinsmaster5
    kevinsmaster5 committed May 1, 2024
    Configuration menu
    Copy the full SHA
    d1a73e9 View commit details
    Browse the repository at this point in the history

  5. check for nil phone value before running limit check

    @kevinsmaster5
    kevinsmaster5 committed May 1, 2024
    Configuration menu
    Copy the full SHA
    7802e47 View commit details
    Browse the repository at this point in the history

  6. explicitly pass parsed phone as string

    @kevinsmaster5
    kevinsmaster5 committed May 1, 2024
    Configuration menu
    Copy the full SHA
    4f3a121 View commit details
    Browse the repository at this point in the history

  7. added check for blank entry and fix for nil string errors that spec s… 

    …urfaced, better lockout
    @kevinsmaster5
    kevinsmaster5 committed May 1, 2024
    Configuration menu
    Copy the full SHA
    bda810a View commit details
    Browse the repository at this point in the history

  8. add test to lock out user exceeding phone submissions

    @kevinsmaster5
    kevinsmaster5 committed May 1, 2024
    Configuration menu
    Copy the full SHA
    546ca7c View commit details
    Browse the repository at this point in the history

  9. expand on phone submission test with additional user and locked attri… 

    …bute
    @kevinsmaster5
    kevinsmaster5 committed May 1, 2024
    Configuration menu
    Copy the full SHA
    c013074 View commit details
    Browse the repository at this point in the history

  10. refactor setup controller to remove logout. update lockout time in ap… 

    …plication config
    @kevinsmaster5
    kevinsmaster5 committed May 1, 2024
    Configuration menu
    Copy the full SHA
    500e098 View commit details
    Browse the repository at this point in the history

  11. redirect failed phone setup to account

    @kevinsmaster5
    kevinsmaster5 committed May 1, 2024
    Configuration menu
    Copy the full SHA
    3730833 View commit details
    Browse the repository at this point in the history

  12. leverages OtpRateLimiter and modifies it to accept another limiter

    @kevinsmaster5
    kevinsmaster5 committed May 1, 2024
    Configuration menu
    Copy the full SHA
    57dbca5 View commit details
    Browse the repository at this point in the history

  13. add limit_type to otp rate limiter spec

    @kevinsmaster5
    kevinsmaster5 committed May 1, 2024
    Configuration menu
    Copy the full SHA
    a37aae9 View commit details
    Browse the repository at this point in the history

  14. add limit_type to sign in and send phone confirmation spec

    @kevinsmaster5
    kevinsmaster5 committed May 1, 2024
    Configuration menu
    Copy the full SHA
    f2ef5b9 View commit details
    Browse the repository at this point in the history

  15. retreat changes after commit 0550b52

    @kevinsmaster5
    kevinsmaster5 committed May 1, 2024
    Configuration menu
    Copy the full SHA
    839626d View commit details
    Browse the repository at this point in the history

  16. rename fingerprint rate limit type

    @kevinsmaster5
    kevinsmaster5 committed May 1, 2024
    Configuration menu
    Copy the full SHA
    deb8d9a View commit details
    Browse the repository at this point in the history

  17. corrects test for user2 2F lockout

    @kevinsmaster5
    kevinsmaster5 committed May 1, 2024
    Configuration menu
    Copy the full SHA
    f8e8474 View commit details
    Browse the repository at this point in the history

  18. standardize rate limiter name, remove no-longer needed returns, redir… 

    …ect to phone setup and remove 2f lockout
    @kevinsmaster5
    kevinsmaster5 committed May 1, 2024
    Configuration menu
    Copy the full SHA
    48e60c3 View commit details
    Browse the repository at this point in the history

  19. move validation to NewPhoneForm

    @kevinsmaster5
    kevinsmaster5 committed May 1, 2024
    Configuration menu
    Copy the full SHA
    7307e18 View commit details
    Browse the repository at this point in the history

  20. rename error to match actual form symbol

    @kevinsmaster5
    kevinsmaster5 committed May 1, 2024
    Configuration menu
    Copy the full SHA
    c16519f View commit details
    Browse the repository at this point in the history

  21. rebase to incorporate phone_setup changes. add to error handling from… 

    … FromResponse
    @kevinsmaster5
    kevinsmaster5 committed May 1, 2024
    Configuration menu
    Copy the full SHA
    934a6cd View commit details
    Browse the repository at this point in the history

  22. revise spec to account for phone setup controller ability to show errors

    @kevinsmaster5
    kevinsmaster5 committed May 1, 2024
    Configuration menu
    Copy the full SHA
    53b187c View commit details
    Browse the repository at this point in the history

  23. revises error message handling and respective test

    @kevinsmaster5
    kevinsmaster5 committed May 1, 2024
    Configuration menu
    Copy the full SHA
    d1c9be8 View commit details
    Browse the repository at this point in the history

  24. revert change to phone setup controller spec

    @kevinsmaster5
    kevinsmaster5 committed May 1, 2024
    Configuration menu
    Copy the full SHA
    5233d20 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. fix error messaging to flash. add testing for error display

    @kevinsmaster5
    kevinsmaster5 committed May 2, 2024
    Configuration menu
    Copy the full SHA
    dcfb36a View commit details
    Browse the repository at this point in the history

  2. remove unneeded symbol from first_error_message

    @kevinsmaster5
    kevinsmaster5 committed May 2, 2024
    Configuration menu
    Copy the full SHA
    650baf8 View commit details
    Browse the repository at this point in the history

  3. cleanup and optimize phone setup spec, downgrade instance variable in… 

    … phone form
    @kevinsmaster5
    kevinsmaster5 committed May 2, 2024
    Configuration menu
    Copy the full SHA
    b67eadd View commit details
    Browse the repository at this point in the history