Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LG-12177: selfie retaken log #10469

Merged
merged 3 commits into from
Apr 19, 2024
Merged

LG-12177: selfie retaken log #10469

merged 3 commits into from
Apr 19, 2024

Conversation

dawei-nava
Copy link
Contributor

馃帿 Ticket

Link to the relevant ticket:
LG-12177

馃洜 Summary of changes

Add event idv_sdk_selfie_image_re_taken of selfie retaken

馃摐 Testing Plan

Provide a checklist of steps to confirm the changes.

  • Step 1: doc auth with selfie
  • Step 2: try capture selfie
  • Step 3: retake the selfie couple of times
  • Step 4: verify the event contains "captureAttemps" and "selfie_attempts"

charleyf
charleyf approved these changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@charleyf charleyf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This logs the idv_sdk_selfie_image_re_taken event. Somewhat surprising that the selfie_attempts only gets updates when the user accepts a selfie, but I think we're doing that intentionally.

app/services/analytics_events.rb Outdated Show resolved Hide resolved
app/services/analytics_events.rb Show resolved Hide resolved
@dawei-nava
LG-12177: test fixes.
4310064 
changelog: Internal, Doc Auth, Analytics event for selfie retake.
@dawei-nava dawei-nava marked this pull request as ready for review April 19, 2024 20:18
@dawei-nava dawei-nava merged commit 4286a2a into main Apr 19, 2024
2 checks passed
@dawei-nava dawei-nava deleted the dwang/LG-12177_selfie_retaken_log branch April 19, 2024 20:19
@jmhooper jmhooper mentioned this pull request Apr 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charleyf charleyf charleyf approved these changes

@night-jellyfish night-jellyfish Awaiting requested review from night-jellyfish

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dawei-nava @charleyf