Move IdentityConfig code into Identity::Hostdata #10476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Most of the changes are automated, but this touches the entire codebase, so merge conflicts are kind of inevitable, my strategy is going to be to:
|
zachmargolis
commented
Apr 22, 2024
- Allows for better sharing across codebases - Keeps "IdentityConfig.store" around to forward, which allows keeping old syntax for now changelog: Internal, Source code, Use shared logic for accessing config data
zachmargolis
force-pushed
the
margolis-identity-hostdata-config
branch
from
897f3ee
to
72a4478
Compare
zachmargolis
commented
Apr 23, 2024
Comment on lines
+12
to
14
| def self.store | ||
| Identity::Hostdata.config | ||
| end |
There was a problem hiding this comment.
I added this shorthand and redid the PR to minimize diff noise
zachmargolis
commented
Apr 23, 2024
|
|
||
| config.asset_sources = AssetSources.new( | ||
| manifest_path: Rails.public_path.join('packs', 'manifest.json'), | ||
| cache_manifest: Rails.env.production? || Rails.env.test?, | ||
| i18n_locales: IdentityConfig.store.available_locales, | ||
| i18n_locales: Identity::Hostdata.config.available_locales, |
There was a problem hiding this comment.
this is now basically the only file that's been migrated to the new syntax
Sgtpluck
approved these changes
Apr 25, 2024
Comment on lines
+12
to
14
| def self.store | ||
| Identity::Hostdata.config | ||
| end |
config/application.rb
Outdated
| @@ -32,24 +32,24 @@ class Application < Rails::Application | |||
| Identity::Hostdata.logger.level = log_level | |||
| end | |||
|
|
|||
| configuration = Identity::Hostdata::ConfigReader.new( | |||
| Identity::Hostdata.load_config!( | |||
| app_root: Rails.root, | |||
| logger: Identity::Hostdata.logger, | |||
There was a problem hiding this comment.
not a big deal, but you could skip passing in the logger value as it evokes as
logger: logger || self.logger
There was a problem hiding this comment.
oh yeah great reminder! updated in 7d3ed90
Co-authored-by: Davida Marion <sgtplt@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See 18F/identity-hostdata#39
Big rename of
IdentityConfig.storetoIdentity::Hostdata.configLets us share code with other repos, as this code has been copy-pasted quite a few times now