Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename UpdateUser to focus on phone attributes #10479

Merged
merged 4 commits into from
Apr 23, 2024

Conversation

zachmargolis
Copy link
Contributor

@zachmargolis zachmargolis commented Apr 22, 2024

  • Inlines most use cases for UpdateUser
  • Renames UpdateUser to UpdateUserPhoneConfiguration because that's where the bulk of the logic is

Possible future work: refactor UpdateUserPhoneConfiguration interface to be more specific about what side effects, such as having something like:

UpdateUserPhoneConfiguration.new(user).update_defaults(
  phone_id: ...
  otp_make_default_number: ...
)

- Inlines most use cases for UpdateUser

changelog: Internal, Source code, Simplify user-updating code
@zachmargolis zachmargolis requested a review from a team April 22, 2024 21:43
@zachmargolis zachmargolis marked this pull request as ready for review April 22, 2024 23:20
Copy link
Member

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactor 👍 I don't think I'd realized UpdateUser had this built-in side effects around phones.

@zachmargolis zachmargolis merged commit c465f01 into main Apr 23, 2024
2 checks passed
@zachmargolis zachmargolis deleted the margolis-remove-update-user branch April 23, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants