Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ci config for reviewapps to use the new helm chart settings #10525

Merged
merged 5 commits into from
Apr 30, 2024

Conversation

voidlily
Copy link
Contributor

Config options to abstract parts of the env vars

@voidlily voidlily force-pushed the reviewapps-env-refactor branch 2 times, most recently from 6a0e849 to ea2aa12 Compare April 29, 2024 21:47
Copy link
Member

@stephencshelton stephencshelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks happy to me!

.gitlab-ci.yml Outdated Show resolved Hide resolved
voidlily and others added 5 commits April 30, 2024 13:54
Config options to abstract parts of the env vars

changelog: Internal, reviewapps, update env to use new helm chart config format
back to main

Co-authored-by: Stephen Shelton <stephen.shelton@gsa.gov>
@voidlily voidlily merged commit b0e0634 into main Apr 30, 2024
2 checks passed
@voidlily voidlily deleted the reviewapps-env-refactor branch April 30, 2024 22:12
samathad2023 pushed a commit that referenced this pull request May 11, 2024
…10525)

* Refactor ci config for reviewapps to use the new helm chart settings

Config options to abstract parts of the env vars

changelog: Internal, reviewapps, update env to use new helm chart config format

Co-authored-by: Stephen Shelton <stephen.shelton@gsa.gov>

---------

Co-authored-by: Stephen Shelton <stephen.shelton@gsa.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants