-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move, rename reCAPTCHA validator as form #10549
Conversation
changelog: Internal, reCAPTCHA, Refactor reCAPTCHA validator as form model
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Tested locally and confirm testing plan expected outcome.
# @param [String] validator_class Class name of validator | ||
# @param [String] form_class Class name of form |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd consider leaving this so it's easier to track over time?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Normally I'd agree if we were already using this in dashboards or saved queries, but I think this was added primarily as a way to diagnose individual log entries, so I don't know that I'm quite as concerned about backwards compatibility?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense then
* Move, rename reCAPTCHA validator as form changelog: Internal, reCAPTCHA, Refactor reCAPTCHA validator as form model * Update more validator references * Disambiguate form variable name
馃帿 Ticket
Supports LG-12873
馃洜 Summary of changes
Continues refactoring in #10540 to rename and move the current validator service classes as forms.
馃摐 Testing Plan
Validate that there are no regressions in the expected behavior of reCAPTCHA phone validation.
Configure reCAPTCHA score threshold in
config/application.yml
+610491570006