LG-12241 & LG-12181 Add Proofing Rate Metrics to DIVR and Update Metrics Names #10566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated the metrics names for DIVR
the methods for proofing rates now read from the IdentityVerificationReport rather than being created in the ProofingRateReport
changelog: Internal, IdV, Add Proofing Rate Metrics to IdentityVerificationReport and rename metrics names
zachmargolis
reviewed
May 7, 2024
Comment on lines
131
to
133
| reports.map do |report| | ||
| report.successfully_verified_users.to_f / report.idv_started | ||
| report.blanket_proofing_rates | ||
| end |
There was a problem hiding this comment.
We could make this:
reports.map(&:blanket_proofing_rates)and honestly probably just inline this (and the other two)
zachmargolis
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃帿 Ticket
LG-12241
LG-12181
馃洜 Summary of changes
Added the methods from the ProofingRateReport to the IdentityVerificationReport and embeded those methods back into the ProofingRateReport.
Also, updated the metrics names in the IdentityVerificationReport