Remove unnecessary allowed_extra_analytics #10617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changelog: Internal, Automated Testing, Fail build on unnecessary allowed_extra_analytics
4 tasks
zachmargolis
approved these changes
May 13, 2024
ThatSpaceGuy
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃洜 Summary of changes
Removes an unnecessary
allowed_extra_analytics.This is being caught by new checks added in #10571, but not failing on
mainin all cases. It fails locally, and sometimes in other pull requests.Further investigation is needed to determine why it only fails in some cases, but this should help unblock any branches impacted by the test failure.
Related Slack discussion: https://gsa-tts.slack.com/archives/C0NGESUN5/p1715632785782359
馃摐 Testing Plan
Verify
rspec spec/requests/rack_attack_spec.rbpasses.