New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FormSteps React component #3952
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
**Why**: History#pushState cannot operate on origin about:blank, the default JSDOM URL
**Why**: setupDocumentCaptureTestDOM is called before _each_ test case within the Acuant tests, whereas the tear down is only called once at the end of the test suite. This has the result that assigning originalWindow in beforeEach may in-fact be tracking the newly-created Acuant DOM as the original. The alternative to this is to tear down after each test case. However, with recent changes, it's assumed that the DOM should be ready to use at import-time, such that this should be safe.
**Why**: To manage common behaviors of form values aggregation and history of a linear, step-based form.
**Why**: These texts are unlikely to change and are already readily available. See: #3952 (comment)
**Why**: Airbnb doesn't document this rule. It's assumed the spirit of the intent of this rule is to ensure consistency of one element per line when splitting elements across multiple lines. This is accounted for by Prettier. However, the rule is more strict in how it allows multiple elements within the same line, in a way which Prettier neither applies, nor does Airbnb prescribe, nor is in contradiction to this spirit of the guideline.
Per the discussions at #3952 (comment) and #3952 (comment), I took another shot at extracting a general-purpose A couple notes:
|
Why: To manage common behaviors of form values aggregation and history of a linear, step-based form.
Screen Recording:
The included example is provided for demonstration only, and is not intended to be styled or representative of a final flow. The intent of these changes is to prepare an apparatus for step-based forms flow which accumulates a single payload object, and which can be revised by the user using their browser history.