Fix status code 401 symbol usage in doc capture polling #4292
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why: So that the server returns the expected status code (401) and doesn't error on an unrecognized status code
There doesn't appear to be much test coverage for this behavior, but I will plan to include some. I'd discovered this in the course of implementing tests for LG-3423 (dedicated controller for doc capture polling).
Reference: https://guides.rubyonrails.org/layouts_and_rendering.html#the-status-option
Because the front-end polling behavior checks only for
200
status code, it likely does not have a user-facing impact:identity-idp/app/javascript/packs/doc_capture_polling.js
Lines 25 to 30 in d391f77
However, the use of an unrecognized status code symbol could produce errors in the server response.