Bundle JavaScript on-demand for JS feature specs #6392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Why**: So that developers don't need to be aware of and expend the effort to run "yarn build" every time before running a JavaScript-enabled feature spec, in order to avoid CSP errors related to the external Webpack dev server host. changelog: Internal, Automated Testing, Improve developer ergonomics for running JavaScript-enabled integration specs
aduth
added a commit
that referenced
this pull request
May 23, 2022
**Why**: Avoid potential conflicts for... 1. Environment variables which can affect intended build output expecting Webpack dev server 2. False negatives for Make "nothing to do" if environment variable would impact build artifact Previously: #6392 changelog: Internal, Automated Testing, Improve developer ergonomics for running JavaScript-enabled integration specs
sheldon-b
added a commit
that referenced
this pull request
May 23, 2022
* Run feature specs prebuild with unset Webpack env **Why**: Avoid potential conflicts for... 1. Environment variables which can affect intended build output expecting Webpack dev server 2. False negatives for Make "nothing to do" if environment variable would impact build artifact Previously: #6392 changelog: Internal, Automated Testing, Improve developer ergonomics for running JavaScript-enabled integration specs * before all -> before suite So that it's run only once for all tests Co-Authored-By: Zach Margolis <zbmargolis@gmail.com> Co-Authored-By: Sheldon Bachstein <bachsteinsk@gmail.com> * Use global to run webpack build once * Bundle CSS Co-authored-by: Zach Margolis <zbmargolis@gmail.com> Co-authored-by: Sheldon Bachstein <bachsteinsk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why: So that developers don't need to be aware of and expend the effort to run
yarn buildevery time before running a JavaScript-enabled feature spec, in order to avoid CSP errors related to the external Webpack dev server host.Testing Instructions:
rspec spec/features/visitors/i18n_spec.rb:68