Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LG-11066 Do not redirect users at the phone step unless they are phone and address rate limited #9345

Merged
merged 2 commits into from
Oct 12, 2023
Merged

LG-11066 Do not redirect users at the phone step unless they are phone and address rate limited #9345

merged 2 commits into from
Oct 12, 2023

Commits on Oct 11, 2023

  1. LG-11066 Do not redirect users at the phone step unless they are phon… 

    …e and address rate limited

Users are being rate limited and encounting the phone error screen even if they can still verify by mail. This commit changes the rate limit logic to allow users to proceed to the phone step if they can still verify their phone or complete verification by mail.

A side-effect of this change is a bug is fixed where the following situation would exist:

1. A user proofed by mail after exhausting phone attempts
2. The user goes to GPO entry and chooses to cancel and start over
3. The user is redirected to the welcome step to start over
4. The welcome step before action observes the user is phone rate limited and sends the user to the phone errors controller
5. The phone errors controller has a before action to confirm the user has completed the phone errors step; the user has not since in this session so they are redirected to the welcome step
6. Steps 4 and 5 complete until there are too many redirects

[skip changelog]
    @jmhooper
    jmhooper committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    b29c2cc View commit details
    Browse the repository at this point in the history

  2. typos and test caption fix

    @soniaconnolly
    soniaconnolly committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    9079a99 View commit details
    Browse the repository at this point in the history