Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing DOD certs #151

Merged
merged 2 commits into from
Jun 8, 2020
Merged

Add missing DOD certs #151

merged 2 commits into from
Jun 8, 2020

Conversation

achapm
Copy link
Contributor

@achapm achapm commented Jun 8, 2020

Adding DOD missing certs

zachmargolis
zachmargolis approved these changes Jun 8, 2020
View reviewed changes
Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look like certs to me, assuming specs will catch errors if they are invalid

stevegsa
stevegsa approved these changes Jun 8, 2020
View reviewed changes
Copy link
Contributor

@stevegsa stevegsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@achapm achapm merged commit 4a9e050 into master Jun 8, 2020
@achapm achapm deleted the add_missing_dod_certs branch June 8, 2020 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmargolis zachmargolis zachmargolis approved these changes

@stevegsa stevegsa stevegsa approved these changes

@jmhooper jmhooper Awaiting requested review from jmhooper

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@achapm @zachmargolis @stevegsa