LG-3167 Send is_auth_cert in token for HSDPD-12 #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevegsa
changed the title
zachmargolis
reviewed
Aug 4, 2020
zachmargolis
approved these changes
Aug 4, 2020
| @@ -134,6 +135,7 @@ | |||
|
|
|||
| it 'returns a token with a uuid and subject' do | |||
| allow(Figaro.env).to receive(:client_cert_escaped).and_return('true') | |||
| allow_any_instance_of(Certificate).to receive(:has_eku?).and_return(true) | |||
There was a problem hiding this comment.
so much stubbing 😭 --- is it possible to create a cert from the PEM below and then modify it and make a new PEM?
stevegsa
changed the title
stevegsa
changed the title
stevegsa
changed the title
zachmargolis
reviewed
Aug 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How: Check for extendedKeyUsage ... 1.3.6.1.5.2.3.4 in the x509 cert extensions and send is_auth_cert boolean back in the token.