LG-11082 Refactor Post Office Search to use FullAddressSearch #1174
Conversation
|
@gina-yamada can you add the sentence: 'Enter an address to find a Post Office near you.' right on top of the full address component? |
@allis-green I am working on getting this sentence added. I checked in with Matt- I am not blocking him so will just update the version in this PR once I get the change made in identity-idp and it published. (PR for identity-idp to make this change)
(Also, only look at section in red- that is the component/piece that will display in the Help Center)
|
|
@gina-yamada I think that a p-tag works great for that string of text. I'll reference the style guide re: your question about ending the sentence with a period. |
|
@gina-yamada I couldn't find anything in the style guide about when not to use a period for paragraph text, so I'm just going to make the call that we should be using a period for that string. |
|
I updated the version of @18f/identity-address-search from 3.0.0 to 3.1.1 since this PR was approved. The text Enter an address to find a post office near you will no be displayed on the Full Address Search Post Office form in the help center. Only when identity-idp translations gets merged in, will all translations end with a period.
|
| const field = getField(); | ||
| expect(field).toBeEnabled(); | ||
| expect(field).toBeVisible(); | ||
| const testData = { |
There was a problem hiding this comment.
nit but does this ever change? seems like a constant. const TEST_DATA or const SAMPLE_ADDRESS
There was a problem hiding this comment.
I don't want this data to change so used const. If we need more data, we can create another const and/or nest it in different blocks. I preferred having one object with keys rather than having 4 different variables for each key. I went with lowerCamelCase to be consistent with the file.
gina-yamada
force-pushed
the
yamada/LG-11082-RefactorToUseFullAddressSearch
branch
from
be0a651
to
9b59f32
Compare
gina-yamada
deleted the
yamada/LG-11082-RefactorToUseFullAddressSearch
branch
馃帿 Ticket
LG-11082 Refactor identity-site to use FullAddressSearch
馃洜 Summary of changes
@18f/identity-address-searchfrom3.0.0to3.1.03.1.1馃摐 Testing Plan
npm ito install latest version of @18f/identity-address-searchshow_po_searchfrom false to true, start the serverhttp://localhost:4000/help/verify-your-identity/verify-your-identity-in-person/find-a-participating-post-office/(Api does not work yet. It is being refactored in another ticket)
馃摳 Screenshots
Before- using AddressSearch
After- using FullAddressSearch
The screenshots below are before the text update was added (address-search v 3.1.0 -- see commit history of this PR). The images below are now outdated as we are using 3.1.1. I am keeping the screenshots in as the additional text was added in the PR out a conversation/review of these images.