This repository has been archived by the owner on Aug 31, 2020. It is now read-only.
Update search.html #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add text to the label element for screen readers.
|
The search functionality still works, but the style is now off, as evidenced by building 18F/guides-template with a
|
|
@mbland Ready!
|
|
Pushed a fix for the test failure, and checked the Guides Template and Handbook with the update. The only thing that doesn't look quite right is the Handbook home page itself, but I figure you know how to fix it on that end. Merging.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add text to the
labelelement for screen readers. Also removing the extraneousdivsurrounding theform.See: http://www.456bereastreet.com/archive/201204/the_html5_placeholder_attribute_is_not_a_substitute_for_the_label_element/
cc @mbland