This repository has been archived by the owner on Jul 30, 2019. It is now read-only.
Unpublished auctions should not be available #903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harrisj
force-pushed
the
unpublished-auctions-are-unavailable
branch
from
87fbd25
to
3a93603
Compare
| end | ||
| context 'start datetime in past, end datetime in past' do | ||
| it 'is false' do | ||
| auction = FactoryGirl.build(:auction, :closed) |
There was a problem hiding this comment.
thoughts on not using FactoryGirl prepend thingy? Seems like we are doing this inconsistently around our test suite.
|
great solution! 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #898
Rather than make an integration test for a negative feature, I just added an rspec test to make sure the status available returns false if the auction is not published