Action items -> Needs attention auctions #987
Conversation
adelevie
force-pushed
the
ad-attention-needed
branch
2 times, most recently
from
6c8e0ee
to
73d2d95
Compare
| @@ -0,0 +1,5 @@ | |||
| class Admin::NeedsAttentionAuctionsController < Admin::BaseController | |||
There was a problem hiding this comment.
thoughts on Admin::Auctions::NeedsAttentionControllerto be more consistent with https://github.com/18F/micropurchase/blob/develop/app/controllers/admin/auctions/closed_controller.rb ?
There was a problem hiding this comment.
I guess so! good call!
|
One naming question otherwise LGTM! Nice thinking getting this all set up before moving into new functionality |
adelevie
force-pushed
the
ad-attention-needed
branch
from
73d2d95
to
358f901
Compare
| @@ -0,0 +1,5 @@ | |||
| class Admin::Auctions::NeedsAttentionController < Admin::BaseController | |||
| def index | |||
| @view_model = Admin::NeedsAttentionAuctionsViewModel.new | |||
There was a problem hiding this comment.
@jessieay should these be renamed, too? to something like Admin::Auctions::NeedsAttentionViewModel?
There was a problem hiding this comment.
yeah I did not do that for the other controller but probably makes sense. If you do it, mind also renaming https://github.com/18F/micropurchase/blob/develop/app/view_models/admin/closed_auctions_list_item_view_model.rb ?
There was a problem hiding this comment.
No problemo
On Tuesday, August 2, 2016, Jessie A. Young notifications@github.com
wrote:
In app/controllers/admin/auctions/needs_attention_controller.rb
#987 (comment):@@ -0,0 +1,5 @@
+class Admin::Auctions::NeedsAttentionController < Admin::BaseController
- def index
- @view_model = Admin::NeedsAttentionAuctionsViewModel.new
yeah I did not do that for the other controller but probably makes sense.
If you do it, mind also renaming
https://github.com/18F/micropurchase/blob/develop/app/view_models/admin/closed_auctions_list_item_view_model.rb
?—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/18F/micropurchase/pull/987/files/358f90120da907053c6e0f39e7bb1291c42e3871#r73193822,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAFTBq1aEURip_BsNYXiyMvoot6JZj8Yks5qb3ZNgaJpZM4JatzG
.
|
Going to merge as-is -- we can rename those view models separately! |
|
Thanks! On Tuesday, August 2, 2016, Jessie A. Young notifications@github.com
|
Lays the groundwork for #939 and the other "Needs attention" stories.