This repository has been archived by the owner on Dec 23, 2017. It is now read-only.
Feature/update election lookup #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@noahmanger: the warning for zip codes with multiple districts is basically unstyled--can you take a look? To test, try 60442 (four districts!) or 19041 (two). |
|
This is working great. The only regression I caught is that the list of districts no longer updates based on the districts in that state. |
… feature/update-election-lookup
|
Should be fixed now @noahmanger. I also added the left half of #591 for review. |
|
Beautiful. I'll style the component on the home page separately. |
noahmanger
pushed a commit
that referenced
this pull request
Sep 8, 2015
Feature/update election lookup
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: the last item from #592 is addressed in 18F/fec-style/pull/69.
[Resolves #592]