New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Timecard "intents" #511

Closed
adelevie opened this Issue Oct 5, 2016 · 3 comments

Comments

Projects
None yet
4 participants
@adelevie
Copy link
Contributor

adelevie commented Oct 5, 2016

As a user, I want a clickable link which will add hours for a specific line item to my current time card so that it's easier to contemporaneously track my time in Tock.

This project is a sealed bid auction.


Acceptance criteria

Scenario: Clicking a link with valid structure

  • Given I am an authenticated Tock user
  • And I have entered a Tock URL* into the browser address bar
  • And it contains an [add hours command]
  • And it defines a valid ‘project number’ value
  • And it defines a numeric ‘hours’ value
  • When I hit submit and load the page
  • Then the defined time will be added to the user’s unsubmitted timecard during the present reporting period for the defined project
  • And my current timecard page will load
  • And that page will display a confirmation message stating, “[Time] hours have been added to [Project name].”
  • And the confirmation message will have an “Undo” link

*Note: URL structure should be /addHours?project=231&hours=1

Scenario: Undoing an ‘Add Hours’ addition

  • Given I am an authenticated Tock user
  • And I am on the timecard page
  • And I just added time to a project via a Tock URL with valid ‘Add Hours’ command and values
  • When I click on the ‘Undo’ link in the confirmation message
  • Then the hours just added will be removed from the defined project
  • And I will see a confirmation message stating, “[Hours value] has been removed from [project name].”

Scenario: Loading a Tock ‘Add Hours’ URL with invalid structure

  • Given I am an authenticated Tock user
  • And I have entered a Tock URL into the browser address bar
  • And it contains the [add hours command]
  • And it does NOT include valid project and hour values
  • When I hit submit and load the page
  • Then my current timecard page will load
  • And it will display an error stating, “Oops. That command was not correct and no time was added to your timecard. Try again by entering a URL with this format: tock.gov/addHours?project=231&hours=1

General acceptance criteria

  • B or better Code Climate grade and 90% or higher test coverage for all modifications.
  • Tests adequately cover any new functionality.
  • Tests run on Travis-CI and do not break the build.
  • A payment URL is specified in your micro-purchase profile so we can pay the award

@adelevie adelevie changed the title Feature: Timecare "intents" Feature: Timecard "intents" Oct 5, 2016

@edmullen

This comment has been minimized.

Copy link
Member

edmullen commented Nov 15, 2016

Commenting to be notified.

@edmullen

This comment has been minimized.

Copy link
Member

edmullen commented Nov 18, 2016

Congratulations @mikejihbe on winning this micro-purchase auction!

To get started, please create a pull request referencing this issue. Then enter the URL to your pull request on the auction page (in 18F's Micro-purchase platform) and click "start work".

@mtorres253

This comment has been minimized.

Copy link
Contributor

mtorres253 commented Nov 22, 2016

Hi @mikejihbe! Let us know if you need help getting started. As explained in the email you received, its best to submit a pull request as soon as you can, so we can address any issues that arise before the deadline.

elg0nz added a commit to MustWin/tock that referenced this issue Nov 23, 2016

elg0nz added a commit to MustWin/tock that referenced this issue Nov 29, 2016

elg0nz added a commit to MustWin/tock that referenced this issue Dec 1, 2016

elg0nz added a commit to MustWin/tock that referenced this issue Dec 1, 2016

elg0nz added a commit to MustWin/tock that referenced this issue Dec 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment