This repository has been archived by the owner on Dec 20, 2023. It is now read-only.
Update application.js to make heading links accessible #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch use of `#` in headings to link icon like in the TTS handbook, to make the heading links accessible to screenreaders. This includes adding the SVG link icon to the application.
|
Hi @jasnakai, @MelissaBraxton and I checked the page build and the image to the link icon is broken. I think that's the only thing that needs to fixed. (I guessed at how to add it, I'm not sure how image assets are added to the UX Guides.) The aria-label is working correctly, hooray! |
This was referenced Feb 14, 2023
|
Redoing this work with #377. |
9 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch use of
#in headings to link icon like in the TTS handbook, to make the heading links accessible to screenreaders. This includes adding the SVG link icon to the application.