This repository has been archived by the owner on Sep 9, 2019. It is now read-only.
Added page title and logo to page template. #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Work as part of Issue# 22. * Changed order of header id and class attributes to be consistent with the rest of the file. * Changed name of header content id to better reflect content. * Fixed incorrect use of the main tag (https://developer.mozilla.org/en-US/docs/Web/HTML/Element/main) which was being used to wrap header content as well as the main content. Replaced with .page div. * Added logo w/homepage link to page template. * Added page title w/ prefix and suffix to page template. * Added 'contentinfo' role to footer tag.
|
Thanks for this, @patrickcate! Looking forward to reviewing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work as part of Issue #22.
the rest of the file.
(https://developer.mozilla.org/en-US/docs/Web/HTML/Element/main) which
was being used to wrap header content as well as the main content.
Replaced with .page div.