Skip to content
This repository has been archived by the owner on Dec 8, 2017. It is now read-only.

contact emails are currently going to github.com/[email address] #80

Closed
leahbannon opened this issue Oct 10, 2014 · 4 comments
Closed

contact emails are currently going to github.com/[email address] #80

leahbannon opened this issue Oct 10, 2014 · 4 comments
Assignees
@gboone
Milestone
4th Sprint: Befor...

Comments

@leahbannon
Copy link
Contributor

Is this an issue with how I entered the data?
@leahbannon leahbannon added this to the Before Demo Day milestone Oct 10, 2014
@meiqimichelle
Copy link
Contributor

I'll take a look. I had it set to detect if there was an '@' in the contact field and then make the link an email address instead of a normal link, but maybe other updates changed the way that path works, and made my solution not work. Will investigate :)

@gboone
Copy link
Contributor

gboone commented Oct 10, 2014

Ah, no, I'll take a look at it.

@gboone
Copy link
Contributor

gboone commented Oct 10, 2014

@meiqimichelle you beat me to it.

@meiqimichelle
Copy link
Contributor

My filter isn't working, that is the problem. I'm apparently having trouble with filters in general -- getting strange behavior, I must be doing something wrong. @gboone feel free to you, might be obvious where the issue is.

gboone pushed a commit that referenced this issue Oct 14, 2014
Fixes #80, contact links should function as expected
ffdc935 
Not totally sure why _this_ worked but @meiqimichelle's didn't. All I did
was capture the contact variable before running it through the conditional.
Apparently Jekyll makes a distinction between `object.variable` and
`variable`.
@gboone gboone mentioned this issue Oct 14, 2014
Merged
meiqimichelle added a commit that referenced this issue Oct 14, 2014
@meiqimichelle
Merge pull request #91 from 18F/issue-80-fix
85fa290 
Fixes #80, contact links should function as expected
gboone pushed a commit that referenced this issue Oct 14, 2014
Fixes #80, contact links should function as expected
b767e6f 
Not totally sure why _this_ worked but @meiqimichelle's didn't. All I did
was capture the contact variable before running it through the conditional.
Apparently Jekyll makes a distinction between `object.variable` and
`variable`.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gboone gboone

Labels
None yet
Projects
None yet
Milestone
4th Sprint: Before Demo Day
Development

No branches or pull requests
3 participants
@gboone @leahbannon @meiqimichelle