Limit injected SVG styles to user cascade origin #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@IDisposable @kitmenke I'd really like this released this week, could you review soon? 🙏🏾 |
ghost
deleted the
|
We getting a min.js soon? |
|
Officially released on NPM and updated here as v2.9.1 |
|
Nice, gonna be using it right away :) |
|
This change made producing an image 4 times slower in my case. It should be optimized or, at the very least, should not be used for non-SVG output where it makes no difference in size. |
|
Yes and it made loading the output SVGs 50 times faster :) I agree but don't know how |
ghost
mentioned this pull request
|
@mohd-akram this has been done for you and will ship soon enough. |
|
Thanks @sndst00m, sorry I didn't get time to look at the PR earlier. I'll try it out and see how it goes! |
Merged
This was referenced Dec 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #36. CC @1904labs. Resolves downstream issue jeffersonlicet/snipped#5.
Using the
unsetandinitialproperties, we inject any user origin styles inline and reduce file sizes by up to 95%. We useintialon the container in order to inject all inherited styling.