Deleted AGG submodule and disabled code relying on AGG. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code relying on agg needs to be ported to use libfreetype directly. We can add freetype as a sumbodule to prevent having uncontrolled external dependencies.
esden
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AGG was causing issues when trying to compile on linux because of libfreetype lib include path issues. @kbob mentioned that we are actually only using AGG for libfreetype so I think we should disable agg and port the code that was using agg to use libfreetype directly and include libfreetype as a submodule to gain control over that dependency.
The code relying on AGG needs to be ported to use libfreetype directly.
We can add libfreetype as a sumbodule to prevent having uncontrolled
external dependencies.