Проверка на запросы в цикле (#32)

#17 Добавлена проверка на запросы в цикле
1C-Company · Aug 11, 2021 · 4b9bf95 · 4b9bf95
1 parent 464de06
commit 4b9bf95
Show file tree

Hide file tree

Showing 22 changed files with 915 additions and 8 deletions.
diff --git a/bundles/com.e1c.v8codestyle.bsl/META-INF/MANIFEST.MF b/bundles/com.e1c.v8codestyle.bsl/META-INF/MANIFEST.MF
@@ -16,12 +16,15 @@ Automatic-Module-Name: com.e1c.v8codestyle.bsl
 Bundle-ActivationPolicy: lazy
 Import-Package: com._1c.g5.v8.bm.core;version="[7.0.0,8.0.0)",
  com._1c.g5.v8.dt.bsl.model;version="[4.0.0,5.0.0)",
+ com._1c.g5.v8.dt.bsl.model.util;version="[4.6.0,5.0.0)",
+ com._1c.g5.v8.dt.bsl.resource;version="[13.0.0,14.0.0)",
  com._1c.g5.v8.dt.bsl.typesystem;version="[9.0.0,10.0.0)",
  com._1c.g5.v8.dt.bsl.util;version="[7.0.0,8.0.0)",
  com._1c.g5.v8.dt.mcore;version="[6.0.0,7.0.0)",
  com._1c.g5.v8.dt.mcore.util;version="[3.6.0,4.0.0)",
  com._1c.g5.v8.dt.metadata.mdclass;version="[8.0.0,9.0.0)",
  com._1c.g5.v8.dt.platform;version="[5.0.0,6.0.0)",
+ com._1c.g5.v8.dt.platform.version;version="[2.13.0,3.0.0)",
  com._1c.g5.wiring;version="[2.0.0,3.0.0)",
  com._1c.g5.wiring.binder;version="[1.0.0,2.0.0)",
  com.e1c.g5.v8.dt.bsl.check;version="[1.0.0,2.0.0)",

diff --git a/bundles/com.e1c.v8codestyle.bsl/markdown/query-in-loop.md b/bundles/com.e1c.v8codestyle.bsl/markdown/query-in-loop.md
@@ -0,0 +1,8 @@
+# query-in-loop
+
+## Noncompliant Code Example
+
+## Compliant Solution
+
+## See
+
diff --git a/bundles/com.e1c.v8codestyle.bsl/markdown/ru/query-in-loop.md b/bundles/com.e1c.v8codestyle.bsl/markdown/ru/query-in-loop.md
@@ -0,0 +1,9 @@
+# query-in-loop
+
+## Неправильно
+
+## Правильно
+
+## См.
+
+https://its.1c.ru/db/pubqlang#content:150:hdoc
diff --git a/bundles/com.e1c.v8codestyle.bsl/plugin.xml b/bundles/com.e1c.v8codestyle.bsl/plugin.xml
@@ -11,21 +11,30 @@
    
     Contributors:
         1C-Soft LLC - initial API and implementation
+        Aleksandr Kapralov - issue #17
  -->
 
 <plugin>
    <extension
          point="com.e1c.g5.v8.dt.check.checks">
+
       <category
             category="com.e1c.v8codestyle"
             description="%category.bls.description"
             id="com.e1c.v8codestyle.bsl"
             title="%category.bsl.title">
       </category>
+
       <check
             category="com.e1c.v8codestyle.bsl"
             class="com.e1c.v8codestyle.internal.bsl.ExecutableExtensionFactory:com.e1c.v8codestyle.bsl.check.StructureCtorTooManyKeysCheck">
       </check>
+
+      <check
+            category="com.e1c.v8codestyle.bsl"
+            class="com.e1c.v8codestyle.internal.bsl.ExecutableExtensionFactory:com.e1c.v8codestyle.bsl.check.QueryInLoopCheck">
+      </check>
+
    </extension>
 
 </plugin>
diff --git a/bundles/com.e1c.v8codestyle.bsl/src/com/e1c/v8codestyle/bsl/check/Messages.java b/bundles/com.e1c.v8codestyle.bsl/src/com/e1c/v8codestyle/bsl/check/Messages.java
@@ -9,6 +9,7 @@
  *
  * Contributors:
  *     1C-Soft LLC - initial API and implementation
+ *     Aleksandr Kapralov - issue #17
  *******************************************************************************/
 /**
  *
@@ -25,10 +26,18 @@ final class Messages
     extends NLS
 {
     private static final String BUNDLE_NAME = "com.e1c.v8codestyle.bsl.check.messages"; //$NON-NLS-1$
+
+    public static String QueryInLoop_check_query_in_infinite_loop;
+    public static String QueryInLoop_description;
+    public static String QueryInLoop_Loop_has_query;
+    public static String QueryInLoop_Loop_has_method_with_query__0;
+    public static String QueryInLoop_title;
+
     public static String StructureCtorTooManyKeysCheck_description;
     public static String StructureCtorTooManyKeysCheck_Maximum_structure_constructor_keys;
     public static String StructureCtorTooManyKeysCheck_Structure_constructor_has_more_than__0__keys;
     public static String StructureCtorTooManyKeysCheck_title;
+
     static
     {
         // initialize resource bundle