Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

G5V8DT-24189 При добавлении обработчика события или команды автоматически размещать его в соответствующей области #1369

Merged
merged 11 commits into from
Nov 14, 2023

Conversation

Kudesunik
Copy link
Collaborator

@Kudesunik Kudesunik commented Oct 16, 2023

Задача: #1040

…ески размещать его в соответствующей области
@Kudesunik Kudesunik self-assigned this Oct 16, 2023
…ески размещать его в соответствующей области

Copyright text change and style changes
@@ -23,6 +23,7 @@ Import-Package: com._1c.g5.ides.ui.texteditor.xtext.embedded;version="[6.0.0,7.0
com._1c.g5.v8.dt.bsl.common;version="[6.0.0,7.0.0)",
com._1c.g5.v8.dt.bsl.documentation.comment;version="[4.0.0,5.0.0)",
com._1c.g5.v8.dt.bsl.model;version="[5.0.0,6.0.0)",
com._1c.g5.v8.dt.bsl.model.util;version="4.7.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

не указана верхняя граница

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Исправлено

* @param nodeAfter {@link INode} to get offsets from, can't be {@code null}
* @return module region information with calculated region offsets or {@code null}
*/
public static ModuleRegionInformation create(IDocument document, INode node, INode nodeAfter)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

публичные статичные методы, должны находиться до конструктора

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Перенесено

Nikita Kuznetsov and others added 6 commits October 18, 2023 10:20
…ески размещать его в соответствующей области

Minor changes
…ески размещать его в соответствующей области
…ески размещать его в соответствующей области

Rename extension point
Versioning
}

/**
* Start offset of module region
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gets

*
* @return offset after region declaration
*/
public int getEndOffset()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gets

*
* @return offset before end of region declaration
*/
public int getBeforeEndOffset()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gets

/**
* {@link BslModuleRegionInformation} constructor
*
* @param insertPosition
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

java-doc и ниже тоже

{
while ((eventOwner = eventOwner.eContainer()) != null)
{
if (eventOwner instanceof NamedElement && eventOwner.eClass().getName().equals("Table")) //$NON-NLS-1$
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

а чего тут такая странная проверка, если это про com._1c.g5.v8.dt.form.model.Table, то, достаточно написать так
eventOwner.eClass() = FormPackage.Literals.TABLE

@MaksimDzyuba MaksimDzyuba changed the base branch from master to edt-2023-3 October 30, 2023 21:32
@MaksimDzyuba
Copy link
Collaborator

Я переподвесил ветку к edt-2023-3, так как по мастеру собираем тут мы именно релиз

Nikita Kuznetsov and others added 3 commits November 1, 2023 11:28
Copy link

sonarcloud bot commented Nov 14, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

3.8% 3.8% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@MaksimDzyuba MaksimDzyuba merged commit b441ad5 into edt-2023-3 Nov 14, 2023
4 of 5 checks passed
@MaksimDzyuba MaksimDzyuba deleted the G5V8DT-24189 branch November 14, 2023 09:45
@marmyshev marmyshev added this to the 0.7 для EDT 2023.3 milestone Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants