-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
G5V8DT-24189 При добавлении обработчика события или команды автоматически размещать его в соответствующей области #1369
Conversation
…ески размещать его в соответствующей области
…ески размещать его в соответствующей области Copyright text change and style changes
@@ -23,6 +23,7 @@ Import-Package: com._1c.g5.ides.ui.texteditor.xtext.embedded;version="[6.0.0,7.0 | |||
com._1c.g5.v8.dt.bsl.common;version="[6.0.0,7.0.0)", | |||
com._1c.g5.v8.dt.bsl.documentation.comment;version="[4.0.0,5.0.0)", | |||
com._1c.g5.v8.dt.bsl.model;version="[5.0.0,6.0.0)", | |||
com._1c.g5.v8.dt.bsl.model.util;version="4.7.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
не указана верхняя граница
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Исправлено
* @param nodeAfter {@link INode} to get offsets from, can't be {@code null} | ||
* @return module region information with calculated region offsets or {@code null} | ||
*/ | ||
public static ModuleRegionInformation create(IDocument document, INode node, INode nodeAfter) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
публичные статичные методы, должны находиться до конструктора
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Перенесено
…ески размещать его в соответствующей области Minor changes
…ески размещать его в соответствующей области
…ески размещать его в соответствующей области Rename extension point Versioning
…ь его в соответствующей области Another refactoring
} | ||
|
||
/** | ||
* Start offset of module region |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gets
* | ||
* @return offset after region declaration | ||
*/ | ||
public int getEndOffset() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gets
* | ||
* @return offset before end of region declaration | ||
*/ | ||
public int getBeforeEndOffset() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gets
/** | ||
* {@link BslModuleRegionInformation} constructor | ||
* | ||
* @param insertPosition |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
java-doc и ниже тоже
{ | ||
while ((eventOwner = eventOwner.eContainer()) != null) | ||
{ | ||
if (eventOwner instanceof NamedElement && eventOwner.eClass().getName().equals("Table")) //$NON-NLS-1$ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
а чего тут такая странная проверка, если это про com._1c.g5.v8.dt.form.model.Table, то, достаточно написать так
eventOwner.eClass() = FormPackage.Literals.TABLE
Я переподвесил ветку к edt-2023-3, так как по мастеру собираем тут мы именно релиз |
…ески размещать его в соответствующей области
…ески размещать его в соответствующей области Code style fixes
SonarCloud Quality Gate failed.
|
Задача: #1040