Routing #57

hkaintz · 2021-07-02T09:54:21Z

No description provided.

vobu · 2021-07-14T13:19:57Z

docs/routing/index.md

+
+With **targets**, you define where a view or a component is loaded and where the view or component is shown on the UI. By referring to one or multiple targets in a route's definition, you can load and show the views or components once the route's pattern matches the current hash.
+
+It is best practice to configure the routing in the descriptor file (`manifest.json`) while it is also possible to do it in the `Component.js` file or locally by calling the constructors of the classes, for example under the `sap.ui.core.routing` and `sap.m.routing` namespaces.


even though technically true of course, i find the bare mention of the non-manifest options rather confusing to the reader. so IMHO i'd either elaborate on both (component, sub-classed routing) in configuration or similar

vobu · 2021-07-14T13:21:23Z

docs/routing/configuration.markdown

+title: Configuration
+name: configuration
+parent: Routing and Navigation
+nav_order: 3


I'd suggest to make this the first sub-nav item after index: config is essential before anything :)

vobu · 2021-07-14T13:22:49Z

docs/routing/patterns.markdown

@@ -0,0 +1,71 @@
+---


all of the route pattern items need a code exmaple IMO - it's really difficult for the reader to translate the prose to code him-/herself

vobu · 2021-07-14T13:24:32Z

docs/routing/configuration.markdown

+
+</div>
+
+## Config


same comment as in patterns: this needs code example to make it "visible" for the reader what the options are all about

vobu · 2021-07-14T13:28:36Z

docs/routing/methods.markdown

+
+## Methods
+
+Navigation can be triggered by method the [navTo](https://sapui5.hana.ondemand.com/#/api/sap.ui.core.routing.Router%23methods/navTo){:target="_blank"} on `sap.ui.core.routing.Router`.


also, try using https://ui5.sap.com as the documentation domain - b/c reasons, you know ... :)

vobu · 2021-07-14T13:29:47Z

docs/routing/methods.markdown

+
+Navigation can be triggered by method the [navTo](https://sapui5.hana.ondemand.com/#/api/sap.ui.core.routing.Router%23methods/navTo){:target="_blank"} on `sap.ui.core.routing.Router`.
+
+You can use a generic navTo method in your BaseController and call it from any controller within your applicataion:


typo "application"

vobu · 2021-07-14T13:31:43Z

docs/routing/methods.markdown

+
+    return Controller.extend("myApp.controller.BaseController",
+
+        navTo: function(sName, oParameters, oComponentTargetInfo, bReplace) {


what about ES6-ing things, à la:

sap.ui.require(..., (Controller) => { navTo(sName, oParameters, ...) { } })

but this just a hint, not a necessity :)

I personally would also prefer always programming ES6, but still a lot of customers I have require apps to also run in IE. Hence I always provide examples in ES5 style.

vobu · 2021-07-14T13:32:15Z

docs/routing/methods.markdown

+
+### RouteMatched
+
+The routeMatched event is fired if a pattern of any route in the routing configuration is matched.


code fence routeMatched

and: the code example shows the handler for the patternMatched event, not the routeMatched

vobu · 2021-07-14T13:34:04Z

docs/routing/methods.markdown

+});
+```
+
+### Matched


this is actually the routeMatched event, right? (see above)

vobu · 2021-07-14T13:35:00Z

docs/routing/titles.markdown

+
+## Titles in Targets
+
+Routing in SAPUI5 allows you to define titles declaratively in the configuration. The title can be set with valid binding syntax which is then resolved under the scope of the target to which it belongs. This means that the title can be translated when it’s bound to the i18n model or resolved dynamically under the current binding context.


marianfoo · 2021-10-07T15:50:14Z

Hi @hkaintz
what´s the current status here?
You need any help?

github-actions · 2021-10-27T10:09:16Z

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

hkaintz · 2021-10-29T11:05:25Z

I have read the CLA Document and I hereby sign the CLA

hkaintz · 2021-10-29T11:31:00Z

I have read the CLA Document and I hereby sign the CLA

treee111 · 2021-10-29T11:45:57Z

Hi @hkaintz you can try this to rewrite the commits.
For example the last 10 commits:
git rebase -i HEAD~10

If it fails you can reset hard from the remote to reset your local branch

hkaintz · 2021-12-02T11:17:39Z

@marianfoo Ich habs gerade mit git rebase versucht, hat leider nicht funktioniert. Die neuen commits haben zwar den richtigen User, aber die Alten sind immer noch da.
Ist es möglich vorübergehend den check zu disablen?

hkaintz · 2021-12-02T11:19:22Z

I have read the CLA Document and I hereby sign the CLA

marianfoo · 2021-12-03T08:12:31Z

@marianfoo Ich habs gerade mit git rebase versucht, hat leider nicht funktioniert. Die neuen commits haben zwar den richtigen User, aber die Alten sind immer noch da. Ist es möglich vorübergehend den check zu disablen?

Hi @hkaintz, ja wir können für diesen Fall trotzdem mergen. Mit deinen GitHub User hast du ja unterschrieben.
@vobu ist mit dem PR alles ok?

feat: initial commit for routing fix: removed non-manifest routing options fix: changed nav order of confi chapter feat: added examples for patterns feat: added example for config fix: minor fixes fix: changed user fix: changed user feat: initial commit for routing fix: removed non-manifest routing options fix: changed nav order of confi chapter feat: added examples for patterns feat: added example for config fix: minor fixes fix: changed user fix: changed user

marianfoo · 2022-01-23T14:54:54Z

@hkaintz fixed Error with "CLA Assistant" by sqashing your commits into one

hkaintz requested a review from vobu July 2, 2021 09:54

hkaintz self-assigned this Jul 2, 2021

vobu suggested changes Jul 14, 2021

View reviewed changes

marianfoo linked an issue Aug 12, 2021 that may be closed by this pull request

Add Herbert to the Topic Collection under the topic Navigation #38

Closed

github-actions bot added a commit that referenced this pull request Oct 29, 2021

@hkaintz has signed the CLA from Pull Request #57

4dbc72b

marianfoo added the new topic create a new topic label Jan 16, 2022

hkaintz and others added 2 commits January 23, 2022 15:51

fix: resolve merge conflict

b69bd24

marianfoo force-pushed the routing branch from ec41610 to b69bd24 Compare January 23, 2022 14:53

marianfoo added 4 commits January 26, 2022 17:49

feat(routing): remove duplicate content

e6c2475

feat(routing): add references to sources

09152c0

Merge branch 'main' into routing

3f11788

fix(routing): change nav order

307b00e

marianfoo merged commit 69cc536 into 1DSAG:main Jun 16, 2022

github-actions bot locked and limited conversation to collaborators Jun 16, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Routing #57

Routing #57

hkaintz commented Jul 2, 2021

vobu Jul 14, 2021

vobu Jul 14, 2021

vobu Jul 14, 2021

vobu Jul 14, 2021

vobu Jul 14, 2021

vobu Jul 14, 2021

vobu Jul 14, 2021

vobu Jul 14, 2021

hkaintz Oct 27, 2021

vobu Jul 14, 2021

vobu Jul 14, 2021

vobu Jul 14, 2021

vobu Jul 14, 2021

marianfoo commented Oct 7, 2021

github-actions bot commented Oct 27, 2021 •

edited

hkaintz commented Oct 29, 2021

hkaintz commented Oct 29, 2021

treee111 commented Oct 29, 2021

hkaintz commented Dec 2, 2021

hkaintz commented Dec 2, 2021

marianfoo commented Dec 3, 2021

marianfoo commented Jan 23, 2022


		With targets, you define where a view or a component is loaded and where the view or component is shown on the UI. By referring to one or multiple targets in a route's definition, you can load and show the views or components once the route's pattern matches the current hash.

		It is best practice to configure the routing in the descriptor file (`manifest.json`) while it is also possible to do it in the `Component.js` file or locally by calling the constructors of the classes, for example under the `sap.ui.core.routing` and `sap.m.routing` namespaces.


		## Methods

		Navigation can be triggered by method the [navTo](https://sapui5.hana.ondemand.com/#/api/sap.ui.core.routing.Router%23methods/navTo){:target="_blank"} on `sap.ui.core.routing.Router`.


		Navigation can be triggered by method the [navTo](https://sapui5.hana.ondemand.com/#/api/sap.ui.core.routing.Router%23methods/navTo){:target="_blank"} on `sap.ui.core.routing.Router`.

		You can use a generic navTo method in your BaseController and call it from any controller within your applicataion:


		return Controller.extend("myApp.controller.BaseController",

		navTo: function(sName, oParameters, oComponentTargetInfo, bReplace) {


		### RouteMatched

		The routeMatched event is fired if a pattern of any route in the routing configuration is matched.


		## Titles in Targets

		Routing in SAPUI5 allows you to define titles declaratively in the configuration. The title can be set with valid binding syntax which is then resolved under the scope of the target to which it belongs. This means that the title can be translated when it’s bound to the i18n model or resolved dynamically under the current binding context.


		</div>

		## Config

Routing #57

Routing #57

Conversation

hkaintz commented Jul 2, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

marianfoo commented Oct 7, 2021

github-actions bot commented Oct 27, 2021 • edited

hkaintz commented Oct 29, 2021

hkaintz commented Oct 29, 2021

treee111 commented Oct 29, 2021

hkaintz commented Dec 2, 2021

hkaintz commented Dec 2, 2021

marianfoo commented Dec 3, 2021

marianfoo commented Jan 23, 2022

github-actions bot commented Oct 27, 2021 •

edited