Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

partEvents do not fire if the character is destroyed inside #53

Closed
1ForeverHD opened this issue Apr 23, 2022 · 1 comment
Closed

partEvents do not fire if the character is destroyed inside #53

1ForeverHD opened this issue Apr 23, 2022 · 1 comment
Labels
Priority: High Scope: Core Type: Bug

Comments

@1ForeverHD
Copy link
Owner

e.g. workspace.ForeverHD:Destroy()

they do however work for player and item events.

more details here: https://devforum.roblox.com/t/zoneplus-v320-construct-dynamic-zones-and-effectively-determine-players-and-parts-within-their-boundaries/1017701/383?u=foreverhd
@Argus74
Copy link

Argus74 commented Sep 26, 2022

Hello, I would like to contribute to repository. Is this issue open?

1ForeverHD added a commit that referenced this issue Sep 27, 2022
@1ForeverHD
Merge pull request #60 from Argus74/fix_parts_events
fc4179c 
Nice job Argus! Thanks for your contributions. I'm aiming to complete a few issues myself next week so will hopefully have these deployed to main along with those. 👍 

In response to your other questions: you're more welcome to submit a PR right-away for minor/easy-to-review changes like these.

This resolves #53
@1ForeverHD 1ForeverHD mentioned this issue Sep 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: High Scope: Core Type: Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@1ForeverHD @Argus74