Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No error handling in ForexDataClient #11

Open
matjazbo opened this issue Nov 18, 2020 · 0 comments
Open

No error handling in ForexDataClient #11

matjazbo opened this issue Nov 18, 2020 · 0 comments

Comments

@matjazbo
Copy link

ForexDataClient class, getQuotes function does not handle errors returned from the API.

For example, if quota has been exceeded, API returns something like:

{
  "error": true
  "message": "Your quota has been used fully.  Quotas reset at midnight EST. If you have any questions please email us at contact@1forge.com"
}

but code ignores that and just tries to read quote data - which doesn't exist and PHP notices get thrown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant