Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboarding: Garden type selection screen #507

Merged
merged 4 commits into from
Jun 24, 2021

Conversation

fabriziovigevani
Copy link
Member

closes 1Hive/gardens#153

TODO:

  • Update garden type icons (icons in screen are placeholders)
  • Define if the garden type paragraph makes sense or it should have more information.

Preview
Screen Shot 2021-06-17 at 15 50 08

@vercel
Copy link

vercel bot commented Jun 17, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/1hive/honey-pot/GT3gjboApESegJRxgNdsEELdSGsH
✅ Preview: https://honey-pot-git-onboarding-garden-type-1hive.vercel.app

Copy link
Member

@0xGabi 0xGabi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! The logic was straight forward with the backbone in place 💪

margin-bottom: ${6 * GU}px;
`}
>
<Card
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonder what you think of also add the handleNext handler to the onSelect prop of each Card?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes i thought about it but wasn't sure, let's do it 👍

Copy link
Member

@0xGabi 0xGabi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's fix the merge conflicts and we can merge it as well. Let's add a couple of new issues to address the TODOs

Base automatically changed from onboarding-backbone to gardens June 24, 2021 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants