Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor : Split QuestService into multiple Contract service + remove shared folder #109

Open
3 tasks
Corantin opened this issue Jan 5, 2022 · 0 comments
Open
3 tasks

Refactor : Split QuestService into multiple Contract service + remove shared folder #109

Corantin opened this issue Jan 5, 2022 · 0 comments
Labels
App 📱 User-facing issues Refactor / Code cleanup / Tech dept Refactor

Comments

@Corantin
Copy link
Collaborator

Corantin commented Jan 5, 2022 •
edited
Loading

DOD :

  • Each contract should have its own service
  • Each contract service should instantiate the contract on init if address is defined by network (change when network change only)
  • Should remove duplicated lines of each contract function
    image.png
@Corantin Corantin changed the title Split QuestService into multiple Contract service + remove shared folder Refactor : Split QuestService into multiple Contract service + remove shared folder Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
App 📱 User-facing issues Refactor / Code cleanup / Tech dept Refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Corantin