Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check failed schedule tx with bad delay #158

Closed
Corantin opened this issue Jan 27, 2022 · 2 comments · Fixed by #181
Closed

Check failed schedule tx with bad delay #158

Corantin opened this issue Jan 27, 2022 · 2 comments · Fixed by #181
Assignees
@kamikazebr
Labels
App 📱 User-facing issues Bug 👩‍✈️ Something isn't working

Comments

@Corantin
Copy link
Collaborator

Corantin commented Jan 27, 2022 •
edited by kamikazebr
Loading

https://rinkeby.etherscan.io/tx/0x9a762d4c1e8e1000515563fd5e0128cccbe36c413957809dcfa3fdf9f7f23f2b

At Tenderly

https://dashboard.tenderly.co/tx/rinkeby/0x9a762d4c1e8e1000515563fd5e0128cccbe36c413957809dcfa3fdf9f7f23f2b

image

The function and the require check where it fails.

image
@Corantin Corantin added App 📱 User-facing issues Bug 👩‍✈️ Something isn't working labels Jan 27, 2022
@Corantin Corantin changed the title Check failed schedule tx : https://rinkeby.etherscan.io/tx/0x9a762d4c1e8e1000515563fd5e0128cccbe36c413957809dcfa3fdf9f7f23f2b Check failed schedule tx with bad delay Jan 27, 2022
@kamikazebr kamikazebr self-assigned this Mar 22, 2022
@kamikazebr
Copy link
Member

kamikazebr commented Mar 22, 2022 •
edited
Loading

The container.payload.executionTime in that tx was 1643250916 (January 27, 2022 02:35:16 UTC+0)

The block.timestamp was Jan-27-2022 02:30:34 AM +UTC

The executionDelay its 300 (seconds i presume) equals 5min.

So the executionTime need be higher and its not because of 18 seconds.

Probably to solve that we should just allow call after timestamp + executionDelay was passed, maybe getting it with subgraph?

@Corantin
Copy link
Collaborator Author

Corantin commented Mar 22, 2022 •
edited
Loading

Yep sounds good to me, here is the subgraph used : https://thegraph.com/hosted-service/subgraph/corantin/govern-1hive-rinkeby. Plz tell me if you don't have access

@kamikazebr kamikazebr linked a pull request Mar 24, 2022 that will close this issue
158 check failed schedule tx with bad delay #181
Merged
@kamikazebr kamikazebr mentioned this issue Mar 24, 2022
Merged
kamikazebr added a commit that referenced this issue Mar 24, 2022
@kamikazebr
Merge pull request #181 from 1Hive/158-check-failed-schedule-tx-with-…
cc80485 
…bad-delay

Solve #158 
- Increased delay from 1min to 15min
- Fix minor typo in api subgraph link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kamikazebr kamikazebr

Labels
App 📱 User-facing issues Bug 👩‍✈️ Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

158 check failed schedule tx with bad delay 1Hive/quests
2 participants
@kamikazebr @Corantin