Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Address below fund input + removed width=500 from fund and exec… #150

Merged
merged 8 commits into from
Jan 27, 2022

Conversation

alexchan0394
Copy link
Collaborator

…ute claim

@vercel
Copy link

vercel bot commented Jan 23, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/1hive/quests/13K8rbYkjHL1Atnhtb2fbWtNipoC
✅ Preview: https://quests-git-quests-112-1hive.vercel.app

@vercel vercel bot temporarily deployed to Preview January 23, 2022 23:08 Inactive
@codecov
Copy link

codecov bot commented Jan 23, 2022

Codecov Report

Merging #150 (f833f8b) into main (4ebd7d1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #150   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           25        25           
  Branches         5         5           
=========================================
  Hits            25        25           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ebd7d1...f833f8b. Read the comment docs.

@@ -136,7 +137,6 @@ export default function FundModal({ quest, onClose = noop }: Props) {
]}
onClose={() => closeModal(false)}
isOpen={opened}
width={500}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The objective if this card is to dynamically have a width around 500 (fit-content) without having to set 500, live it's too big. The CSS have to be done in ModalBase
image

@@ -151,6 +151,7 @@ export default function FundModal({ quest, onClose = noop }: Props) {
value={values.fundAmount}
wide
/>
<AddressFieldInput id="address" value={quest.address} isLoading={loading} />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should label it like : label="Quest address"

@vercel vercel bot temporarily deployed to Preview January 25, 2022 23:46 Inactive
@vercel vercel bot temporarily deployed to Preview January 26, 2022 01:37 Inactive
@vercel vercel bot temporarily deployed to Preview January 26, 2022 02:01 Inactive
@vercel vercel bot temporarily deployed to Preview January 27, 2022 01:24 Inactive
@vercel vercel bot temporarily deployed to Preview January 27, 2022 02:18 Inactive
Copy link
Collaborator

@Corantin Corantin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only missing the execute claim

@vercel vercel bot temporarily deployed to Preview January 27, 2022 02:59 Inactive
@alexchan0394 alexchan0394 merged commit 2ceebad into main Jan 27, 2022
@alexchan0394 alexchan0394 deleted the quests-112 branch January 27, 2022 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants