Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

back to top button in main-view #188

Merged
merged 2 commits into from
Mar 27, 2022
Merged

back to top button in main-view #188

merged 2 commits into from
Mar 27, 2022

Conversation

alexchan0394
Copy link
Collaborator

No description provided.

@vercel
Copy link

vercel bot commented Mar 26, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/1hive/quests/HaWc18rWnu2vJy6e94AtCK7mFigo
✅ Preview: https://quests-git-quests-184-1hive.vercel.app

@codecov
Copy link

codecov bot commented Mar 26, 2022 •
edited
Loading

Codecov Report

Merging #188 (0be24f5) into main (948862d) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #188   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           25        25           
  Branches         5         5           
=========================================
  Hits            25        25

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 948862d...0be24f5. Read the comment docs.

@Corantin Corantin linked an issue Mar 27, 2022 that may be closed by this pull request
Back to top button #184
Closed
Corantin
Corantin requested changes Mar 27, 2022
View reviewed changes
Copy link
Collaborator

@Corantin Corantin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to have an icon instead of text. You may have to adjust the padding ..

packages/react-app/src/components/back-to-top.tsx Outdated Show resolved Hide resolved
packages/react-app/src/components/back-to-top.tsx Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview March 27, 2022 18:49 Inactive
@Corantin Corantin self-requested a review March 27, 2022 19:10
@alexchan0394 alexchan0394 merged commit 938b5f3 into main Mar 27, 2022
@alexchan0394 alexchan0394 deleted the quests-184 branch March 27, 2022 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Corantin Corantin Corantin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Back to top button
2 participants
@alexchan0394 @Corantin