Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

done #192

Merged
merged 4 commits into from
Mar 31, 2022
Merged

done #192

merged 4 commits into from
Mar 31, 2022

Conversation

kafann
Copy link
Collaborator

@kafann kafann commented Mar 28, 2022

close #105

@vercel
Copy link

vercel bot commented Mar 28, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/1hive/quests/onHPDEm8KMZ4Modtsth1xrhv38Bs
✅ Preview: https://quests-git-handle-formik-errors-1hive.vercel.app

@codecov
Copy link

codecov bot commented Mar 28, 2022

Codecov Report

Merging #192 (fc0d8c5) into main (938b5f3) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #192   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           25        25           
  Branches         5         5           
=========================================
  Hits            25        25           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 938b5f3...fc0d8c5. Read the comment docs.

Copy link
Collaborator

@Corantin Corantin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On peut enlever "Validation :" c'etait utile avant paskke ct un toast mais la c obvious paske c rouge et en dessous du input
image

Copy link
Collaborator

@Corantin Corantin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing Number field input for HnadleBlur (should be easy quick)

packages/react-app/src/components/quest.tsx Outdated Show resolved Hide resolved
packages/react-app/src/components/quest.tsx Outdated Show resolved Hide resolved
packages/react-app/src/components/quest.tsx Outdated Show resolved Hide resolved
packages/react-app/src/components/quest.tsx Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview March 29, 2022 00:51 Inactive
Copy link
Collaborator

@Corantin Corantin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just missing the Amount Field Input, I'll try to do it soon

@vercel vercel bot temporarily deployed to Preview March 31, 2022 15:47 Inactive
@vercel vercel bot temporarily deployed to Preview March 31, 2022 16:17 Inactive
@kafann kafann closed this Mar 31, 2022
@kafann kafann reopened this Mar 31, 2022
@kafann kafann merged commit 8f5cc4a into main Mar 31, 2022
@kafann kafann deleted the handle-formik-errors branch March 31, 2022 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle form errors with formik
3 participants