Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] uniswap and network #215

Merged
merged 4 commits into from
Apr 13, 2022
Merged

[Fix] uniswap and network #215

merged 4 commits into from
Apr 13, 2022

Conversation

kamikazebr
Copy link
Member

@kamikazebr kamikazebr commented Apr 9, 2022 •
edited
Loading

  • Fixed the calculations and depedency lib uniswap
  • Small fix tabindex typos

@kamikazebr
refact: uniswap
cd9cb1e 
fix: total usd values
fix: commented to remove all unsed methods
@kamikazebr
chore: clean up
81783e4
@kamikazebr
fix: auto connect
7b9148c 
fix: multiple bignumber
@vercel
Copy link

vercel bot commented Apr 9, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/1hive/quests/5htKJusyC4kTJ3rpHRzTodaX11xm
✅ Preview: https://quests-git-fix-uniswap-and-network-1hive.vercel.app

@codecov
Copy link

codecov bot commented Apr 9, 2022 •
edited
Loading

Codecov Report

Merging #215 (7a92019) into main (96d8a31) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #215   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           25        25           
  Branches         5         5           
=========================================
  Hits            25        25

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96d8a31...7a92019. Read the comment docs.

@kamikazebr kamikazebr requested a review from Corantin April 9, 2022 21:14
@kamikazebr kamikazebr self-assigned this Apr 9, 2022
@kamikazebr kamikazebr marked this pull request as ready for review April 9, 2022 21:14
@kamikazebr kamikazebr mentioned this pull request Apr 10, 2022
Closed
3 tasks
@Corantin
Copy link
Collaborator

Corantin commented Apr 11, 2022 •
edited
Loading

Dashboard should be formated with 2 decimals ? sorry I didn't thought about that first time
image

Corantin
Corantin approved these changes Apr 11, 2022
View reviewed changes
Copy link
Collaborator

@Corantin Corantin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good for me, just maybe format the dashboard total to 2 decimals

packages/react-app/src/components/field-input/amount-field-input.tsx Show resolved Hide resolved
packages/react-app/src/services/uniswap.service.ts Show resolved Hide resolved
packages/react-app/src/utils/web3.utils.ts Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview April 13, 2022 22:22 Inactive
@kamikazebr kamikazebr merged commit 18cfc43 into main Apr 13, 2022
@kamikazebr kamikazebr deleted the fix-uniswap-and-network branch April 13, 2022 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Corantin Corantin Corantin approved these changes

Assignees

@kamikazebr kamikazebr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kamikazebr @Corantin