-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refact/Fix] typescript styled components #219
Changes from 17 commits
47436af
95f32ef
fe7c1af
8905283
bfbb88e
0991f8d
c46c2f1
aafe882
df4703c
b829070
cacd560
1edd84c
6d56bbf
9d7dae8
36d9d39
36a1e9c
aa113a9
433a985
3cbe290
61ee6fe
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -42,6 +42,7 @@ | |
"react/no-unused-prop-types": "warn", | ||
"jsx-props-no-spreading": "off", | ||
"react/jsx-props-no-spreading": "off", | ||
"react/state-in-constructor": "off", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Needed because some preset (i think airbnb) and the ErrorBoundary component dont have constructor to receive the props. |
||
"no-unused-vars": ["warn", { "argsIgnorePattern": "^_" }] | ||
}, | ||
"settings": { | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -87,19 +87,20 @@ | |
"@babel/plugin-transform-react-jsx-source": "^7.12.13", | ||
"@babel/preset-env": "^7.7.4", | ||
"@babel/preset-react": "^7.7.4", | ||
"@babel/preset-typescript": "^7.16.7", | ||
"@sentry/webpack-plugin": "^1.15.1", | ||
"@testing-library/react-hooks": "^7.0.2", | ||
"@testing-library/react-hooks": "^8.0.0", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. They fixed the react problem with versions, it was getting react 18 |
||
"@types/jest": "^27.4.1", | ||
"@types/lodash-es": "^4.17.5", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. its the same |
||
"@types/node": "^16.11.0", | ||
"@types/react": "^17.0.30", | ||
"@types/react-dom": "^17.0.9", | ||
"@types/react-router-dom": "^5.3.1", | ||
"@types/styled-components": "^5.1.25", | ||
"@typescript-eslint/eslint-plugin": "^5.0.0", | ||
"@typescript-eslint/parser": "^5.0.0", | ||
"@types/lodash-es": "^4.17.5", | ||
"@types/react-router-dom": "^5.3.1", | ||
"@types/styled-components": "^5.1.15", | ||
"babel-eslint": "^10.1.0", | ||
"babel-plugin-styled-components": "^1.10.6", | ||
"babel-plugin-styled-components": "^2.0.7", | ||
"babel-plugin-transform-class-properties": "^6.24.1", | ||
"cross-env": "^7.0.2", | ||
"eslint-config-prettier": "^8.1.0", | ||
|
@@ -142,7 +143,9 @@ | |
"ci": "yarn install --pure-lockfile" | ||
}, | ||
"resolutions": { | ||
"styled-components": "^5" | ||
"styled-components": "^5", | ||
"@types/react": "17.0.44", | ||
"@types/react-dom": "17.0.15" | ||
Comment on lines
+147
to
+148
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixed the react types using resolutions |
||
}, | ||
"jest": { | ||
"setupFiles": [ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It exist inside the react-preset