Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

done for challenge modal and schedule claim modal #313

Merged
merged 5 commits into from
Jun 20, 2022
Merged

done for challenge modal and schedule claim modal #313

merged 5 commits into from
Jun 20, 2022

Conversation

kafann
Copy link
Collaborator

@kafann kafann commented Jun 8, 2022

close #299

@kafann kafann requested a review from Corantin June 8, 2022 04:58
@kafann kafann self-assigned this Jun 8, 2022
@vercel
Copy link

vercel bot commented Jun 8, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
quests ✅ Ready (Inspect) Visit Preview Jun 20, 2022 at 1:01AM (UTC)

@codecov
Copy link

codecov bot commented Jun 8, 2022 •
edited

Codecov Report

Merging #313 (cd8078f) into dev (bb44e1d) will not change coverage.
The diff coverage is n/a.

❗ Current head cd8078f differs from pull request most recent head cb60e86. Consider uploading reports for the commit cb60e86 to get more accurate results

@@            Coverage Diff            @@
##               dev      #313   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines           56        56           
  Branches        13        13           
=========================================
  Hits            56        56

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb44e1d...cb60e86. Read the comment docs.

@vercel vercel bot temporarily deployed to Preview June 8, 2022 05:06 Inactive
Corantin
Corantin requested changes Jun 8, 2022
View reviewed changes
Copy link
Collaborator

@Corantin Corantin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just missing this after the transaction is completed successfully
image

Corantin
Corantin requested changes Jun 8, 2022
View reviewed changes
packages/react-app/src/components/modals/schedule-claim-modal.tsx Outdated
({ parsedAmount: 0, token: questTotalBounty?.token } as TokenAmountModel),
claimAll: claimDataState.claimAll ?? false,
contactInformation: claimDataState.contactInformation ?? undefined,
playerAddress: claimDataState.playerAddress ?? undefined,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sa peut pas etre null ou undefined playerAddress
si tu veux fallback a undefiend si c vide faudrait tu remplace ?? pas || (y va check pour les nullish a smoment la)
image

packages/react-app/src/components/modals/schedule-claim-modal.tsx Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview June 18, 2022 17:40 Inactive
@kafann kafann added the To be reviewed When a pr is ready to be reviewed label Jun 18, 2022
@Corantin Corantin merged commit f09a50e into dev Jun 20, 2022
@Corantin Corantin deleted the retain-form-content branch June 20, 2022 00:59
@vercel vercel bot temporarily deployed to Preview June 20, 2022 01:01 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Corantin Corantin Corantin requested changes

Assignees

@kafann kafann

Labels
To be reviewed When a pr is ready to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kafann @Corantin @KevinMansour