Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace inline style with hidden attribute. #26

Merged
merged 2 commits into from
Jul 14, 2023
Merged

Replace inline style with hidden attribute. #26

merged 2 commits into from
Jul 14, 2023

Commits on Jul 13, 2023

  1. Replace inline style with hidden attribute. 

    The hidden attribute serves the purpose of hiding content from the
document. We can have multiple display options rather that `block`
specially with responsive design where having different display value
based on the viewport might be required. Switching to the hidden
attribute allow us to control the diplay with ease and shift the display
to the CSS files.

I had to set the display of the hidden element to none with important to
ensure having a spcificity higher than the target elements if there are
other display values applied to them.
    @ahmadalfy
    ahmadalfy committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    2b97b75 View commit details
    Browse the repository at this point in the history

  2. Remove modification made to CSS

    @ahmadalfy
    ahmadalfy committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    ac09be3 View commit details
    Browse the repository at this point in the history