Replace inline style with hidden attribute.
#26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hidden attribute serves the purpose of hiding content from the document. We can have multiple display options rather that `block` specially with responsive design where having different display value based on the viewport might be required. Switching to the hidden attribute allow us to control the diplay with ease and shift the display to the CSS files. I had to set the display of the hidden element to none with important to ensure having a spcificity higher than the target elements if there are other display values applied to them.
|
This is very cool! I haven't seen this approach before. |
|
Following up on your comment about applying modifications to the CSS, I've removed it. It is still behaving and looking like before. |
|
Nice idea🔥 |
https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/hidden |
|
Cool approach |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hidden attribute serves the purpose of hiding content from the document. We can have multiple display options rather that
blockspecially with responsive design where having different display value based on the viewport might be required. Switching to the hidden attribute allow us to control the display with ease and shift the display to the CSS files.I had to set the display of the hidden element to none with important to ensure having a specificity higher than the target elements if there are other display values applied to them.