Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 远程下载文件忽略证书 #3188

Merged
merged 1 commit into from
Dec 5, 2023
Merged

feat: 远程下载文件忽略证书 #3188

merged 1 commit into from
Dec 5, 2023

Conversation

zhengkunwang223
Copy link
Collaborator

Refs #2950

@f2c-ci-robot f2c-ci-robot
Copy link

f2c-ci-robot bot commented Dec 5, 2023

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@1Panel-bot 1Panel-bot added the dev label Dec 5, 2023
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

ssongliu
ssongliu reviewed Dec 5, 2023
View reviewed changes
Copy link
Collaborator

@ssongliu ssongliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm label Dec 5, 2023
@wanghe-fit2cloud
Copy link
Member

/approve

@f2c-ci-robot f2c-ci-robot
Copy link

f2c-ci-robot bot commented Dec 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wanghe-fit2cloud

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved label Dec 5, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 592a1b1 into dev Dec 5, 2023
6 checks passed
@f2c-ci-robot f2c-ci-robot bot deleted the pr@dev@file branch December 5, 2023 08:30
@NHZEX
Copy link

NHZEX commented Dec 13, 2023

应该在UI中给出可选项，硬编码忽略验证有中间人攻击的风险

@NHZEX NHZEX mentioned this pull request Dec 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssongliu ssongliu ssongliu left review comments

@wangdan-fit2cloud wangdan-fit2cloud Awaiting requested review from wangdan-fit2cloud

@wanghe-fit2cloud wanghe-fit2cloud Awaiting requested review from wanghe-fit2cloud

Assignees

@ssongliu ssongliu

Labels
approved dev do-not-merge/release-note-label-needed lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@zhengkunwang223 @wanghe-fit2cloud @NHZEX @ssongliu @1Panel-bot