Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: php运行环境支持第三方商店app #3253

Merged
merged 3 commits into from
Dec 12, 2023

Conversation

qwenode
Copy link
Contributor

@qwenode qwenode commented Dec 10, 2023

What this PR does / why we need it?

php运行环境支持第三方商店app

Copy link

f2c-ci-robot bot commented Dec 10, 2023

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

f2c-ci-robot bot commented Dec 10, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign wangdan-fit2cloud for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@qwenode qwenode changed the title feat: php运行环境支持第三方商店app feat: php运行环境支持第三方商店app #3252 Dec 10, 2023
@qwenode qwenode changed the title feat: php运行环境支持第三方商店app #3252 feat: php运行环境支持第三方商店app Dec 10, 2023
@qwenode qwenode changed the title feat: php运行环境支持第三方商店app feat: php运行环境支持第三方商店app #3252 Dec 10, 2023
@qwenode qwenode changed the title feat: php运行环境支持第三方商店app #3252 feat: php运行环境支持第三方商店app Dec 10, 2023
@qwenode
Copy link
Contributor Author

qwenode commented Dec 10, 2023

#3252 3252

@zhengkunwang223
Copy link
Collaborator

zhengkunwang223 commented Dec 11, 2023

修改这部分逻辑可能会影响很多地方 比如网站 PHP 版本切换, 参数修改,备份 恢复 等
所以此 Pr 暂时不会合并
如果你已经测试过 可以提交一下测试结果并告知我们
可以添加我的企业微信
image
参与1Panel的研发

@qwenode
Copy link
Contributor Author

qwenode commented Dec 11, 2023

@zhengkunwang223
已经在本地环境上测试了 php 版本切换, 网站备份还原, 整机快照还原, 全部正常

image

@zhengkunwang223
Copy link
Collaborator

@zhengkunwang223 已经在本地环境上测试了 php 版本切换, 网站备份还原, 整机快照还原, 全部正常

image

感谢反馈 我们会尽快合并

@wanghe-fit2cloud wanghe-fit2cloud merged commit d60e816 into 1Panel-dev:dev Dec 12, 2023
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants