Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 应用搜索支持描述字段 #3473

Merged
merged 1 commit into from
Dec 28, 2023
Merged

feat: 应用搜索支持描述字段 #3473

merged 1 commit into from
Dec 28, 2023

Conversation

zhengkunwang223
Copy link
Collaborator

Refs #2041

Copy link

f2c-ci-robot bot commented Dec 28, 2023

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@@ -92,7 +92,7 @@ func (c *CommonRepo) WithLikeName(name string) DBOption {
if len(name) == 0 {
return g
}
return g.Where("name like ?", "%"+name+"%")
return g.Where("name like ? or short_desc_zh like ? ", "%"+name+"%", "%"+name+"%")
}
Copy link
Collaborator

@ssongliu ssongliu Dec 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是不是把 short_desc_en 也加上

Copy link

sonarcloud bot commented Dec 28, 2023

Copy link
Member

@wanghe-fit2cloud wanghe-fit2cloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@wanghe-fit2cloud
Copy link
Member

/approve

Copy link

f2c-ci-robot bot commented Dec 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wanghe-fit2cloud

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit 3acd449 into dev Dec 28, 2023
5 checks passed
@f2c-ci-robot f2c-ci-robot bot deleted the pr@dev@app branch December 28, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants