Feat: Deploy only operator with external connect url #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
July 16, 2023 17:24
…connect server is not deployed in Kubernetes.
# Conflicts: # charts/connect/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
I have deployed a 1pwd connect server outside of my Kubernetes cluster and wanted to access it with the Kubernetes operator. I could not find a simple way to set a connect url for the operator, that do not exist in the Kubernetes cluster using this helm chart.
Solution
I added a new variable in the values.yaml that makes it possible to specify a url to a connect server. It is can only be set when the connect server is not deployed through this helm chart.
Please let me know if there are any improvements needed or if there is a better way to solve this issue.