Move CRD out of templates into crds dir #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per the Helm 3 recommendations https://helm.sh/docs/chart_best_practices/custom_resource_definitions/. This does mean that we lose the ability to template.
|
Can you update the README to explain the changes here? |
|
suuuuuuuupppper keen for this one 🙏 We have a multi namespace setup and we want to run the operator for each namespace. Any idea when we might expect this to get released ? |
thatguygriff
approved these changes
Apr 29, 2021
|
@mikeywaites We'll do a release early next week! |
|
Amazing!
Really appreciate it. Look forward testing it out
On Thu, 29 Apr 2021 at 19:24, Floris van der Grinten < ***@***.***> wrote:
@mikeywaites <https://github.com/mikeywaites> We'll do a release early
next week!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#36 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADXGGKYU5FISAMCJTOILX3TLGP4RANCNFSM43XLHC3A>
.
--
Regards
Mike
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the Helm 3 recommendations the CRD is now removed from the
templatesdir to thecrdsdir. This does mean that we lose the ability to template.So previously, the way to skip the CRD would be
--set operator.create=false, but now you'd have to set--skip-crds.