Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TOTP field for the Field class #33

Merged
merged 2 commits into from Mar 24, 2022
Merged

Add TOTP field for the Field class #33

merged 2 commits into from Mar 24, 2022

Conversation

edif2008
Copy link
Member

@edif2008 edif2008 commented Jan 8, 2022

Starting with Connect 1.4.0 we introduced the capability to get the totp value through Connect. Now the SDK supports that as well.

@codecov-commenter
Copy link

Codecov Report

Merging #33 (aeb8a42) into main (678d607) will increase coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #33      +/-   ##
==========================================
+ Coverage   76.08%   76.22%   +0.14%     
==========================================
  Files          21       21              
  Lines        1597     1607      +10     
==========================================
+ Hits         1215     1225      +10     
  Misses        382      382              
Impacted Files Coverage Δ
src/onepasswordconnectsdk/models/field.py 82.35% <100.00%> (+1.44%) ⬆️
src/tests/test_client_items.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 678d607...aeb8a42. Read the comment docs.

With Connect 1.4.0 we introduced the capability to get the totp value through Connect. Now the SDK supports that as well.
@edif2008 edif2008 merged commit 22e75d2 into main Mar 24, 2022
@edif2008 edif2008 deleted the feature/totp branch March 24, 2022 17:59
@github-actions github-actions bot mentioned this pull request Dec 5, 2022
2 tasks
@jpcoenen jpcoenen mentioned this pull request Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants