Add Status field to OnePasswordItem resource #118
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to see whehter the controller succeeded in creating the Kubernetes secret for a OnePasswordItem. A user or tool can just look at the
status
field to see whether the Kubernetes secret has successfully been created. If something went wrong, you can just inspect the status field to see the related error. This instead of having to dig into the logs.Examples
Success example:
Error example:
References
The topic of status/condition is somewhat confusing and there are many ways to do things. Here are some references I used:
Closes #52