Migrate operator updates #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edif2008
reviewed
Oct 21, 2022
volodymyrZotov
force-pushed
the
migrate-operator-updates
branch
from
f5c40d0
to
2712e9c
Compare
edif2008
reviewed
Oct 24, 2022
Comment on lines
+102
to
+107
| **Undeploy Operator** | ||
|
|
||
| ``` | ||
| make undeploy | ||
| ``` | ||
|
|
There was a problem hiding this comment.
We should do one of the following here:
- Warn the users that this command will also delete the namespace where the operator is deployed
- Make the command not delete the namespace
I'd go with the second option for being more safe: let's delete just what we've created 😄
There was a problem hiding this comment.
Agree. We should not delete the namesapce on undeploy.
| ## Setup | ||
|
|
||
| Prerequisites: | ||
|
|
||
| - [1Password Command Line Tool Installed](https://1password.com/downloads/command-line/) | ||
| - [kubectl installed](https://kubernetes.io/docs/tasks/tools/install-kubectl/) | ||
| - [docker installed](https://docs.docker.com/get-docker/) | ||
| - [Generated a 1password-credentials.json file and issued a 1Password Connect API Token for the K8s Operator integration](https://support.1password.com/secrets-automation/) | ||
| - [1Password Connect deployed to Kubernetes](https://support.1password.com/connect-deploy-kubernetes/#step-2-deploy-a-1password-connect-server). **NOTE**: If customization of the 1Password Connect deployment is not required you can skip this prerequisite. | ||
| - [Generated a 1password-credentials.json file and issued a 1Password Connect API Token for the K8s Operator integration](https://developer.1password.com/docs/connect/get-started/#step-1-set-up-a-secrets-automation-workflow) |
There was a problem hiding this comment.
This phrasing is inconsistent compared to the others.
I'd suggest something like this:
Suggested change
| - [Generated a 1password-credentials.json file and issued a 1Password Connect API Token for the K8s Operator integration](https://developer.1password.com/docs/connect/get-started/#step-1-set-up-a-secrets-automation-workflow) | |
| - [A `1password-credentials.json` file generated and a 1Password Connect API Token issues for the K8s Operator integration](https://developer.1password.com/docs/connect/get-started/#step-1-set-up-a-secrets-automation-workflow) |
There was a problem hiding this comment.
Sounds better🙂
Comment on lines
22
to
23
| - [kubectl installed](https://kubernetes.io/docs/tasks/tools/install-kubectl/) | ||
| - [docker installed](https://docs.docker.com/get-docker/) |
There was a problem hiding this comment.
Suggested change
| - [kubectl installed](https://kubernetes.io/docs/tasks/tools/install-kubectl/) | |
| - [docker installed](https://docs.docker.com/get-docker/) | |
| - [`kubectl` installed](https://kubernetes.io/docs/tasks/tools/install-kubectl/) | |
| - [`docker` installed](https://docs.docker.com/get-docker/) |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the updates in README and a couple of more major changes.
make docker-buildcreates an image calledcontroller, therefore we want to use it in theconfig/manager/manager.yamlmanifest.I tried to change the image name to some custom in Makefile but it brakes everything. Need further investigation on what needs to be done to change it. I think it's ok to go with the default one for now.
There was hardcoded
namespaceinconfig/default/kastomization.yaml, therefore it deployed the operator only there.I adjusted
make deploycommand to use the current user's kubectl config namespace. So, users can control where they want to deploy the operator.